This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv2] powerpc: POWER8 memcpy optimization for cached memory
- From: "Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>
- To: Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
- Cc: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, Rajalakshmi Srinivasaraghavan <raji at linux dot vnet dot ibm dot com>
- Cc:
- Date: Mon, 11 Dec 2017 10:44:43 -0200
- Subject: Re: [PATCHv2] powerpc: POWER8 memcpy optimization for cached memory
- Authentication-results: sourceware.org; auth=none
- References: <87vaik8uxy.fsf@linux.vnet.ibm.com> <20171208194020.5005-1-tuliom@linux.vnet.ibm.com> <f1c28160-ea24-50ab-eaa8-b75707a31202@redhat.com>
Florian Weimer <fweimer@redhat.com> writes:
> On 12/08/2017 08:40 PM, Tulio Magno Quites Machado Filho wrote:
>> +@deftp Tunable glibc.tune.cached_memopt
>> +The @code{glibc.tune.cached_memopt=[0|1]} tunable allows the user to enable
>> +optimizations recommended to cacheable memory.
>> +
>> +This tunable is specific to powerpc, powerpc64 and powerpc64le.
>> +@end deftp
>
> I think this has a slight grammar problem.
>
> What about this instead?
>
> The @code{glibc.tune.cached_memopt=[0|1]} tunable allows the user to
> enable optimizations recommended for cacheable memory. If set to
> @code{1}, @theglibc{} assumes that the process memory image consists of
> cacheable (non-device) memory only. The default, @code{0}, indicates
> that the process may use device memory.
And a much better description.
> (I think it's best not to mention string functions here because it is
> impossible to describe how glibc.tune.cached_memopt affects them due to
> compiler optimizations.)
Ack.
Fixed locally.
Thanks!
--
Tulio Magno