This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 09/17] Regex: Add undefs of various routines and macros.

Florian Weimer <fweimer@redhat.com> wrote:

> On 12/08/2017 10:16 AM, Arnold Robbins wrote:
> > +# ifdef inline
> > +# undef inline
> > +# endif
> > +# define inline
>
> Indentation is off.  This also applies to the other patch hunk.
>
> These macro manipulations could break system headers, and it seems that 
> at least <stdint.h> is included after them, so maybe the include order 
> needs changing.
>
> Thanks,
> Florian

This is the kind of thing I'll ask the GLIBC maintainers to handle
if / when they integrate. 

Thanks,

Arnold
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]