This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCHv6] New generic sinf




On 11/30/2017 10:44 PM, Joseph Myers wrote:
On Thu, 30 Nov 2017, Rajalakshmi Srinivasaraghavan wrote:

+	      exponent =
+	        (exponent >> FLOAT_EXPONENT_SHIFT) - FLOAT_EXPONENT_BIAS;

Break lines before operators, not after.

Pushed as 7863a7118112fe502e8020a0db0fa74fef281f29 addressing this comment and Paul Clarke's comments on v6 patch.


OK with that fix (remember of course to resolve bug 5997 as FIXED with
target milestone set to 2.27 when checking in the patch).

Thanks for the review.



--
Thanks
Rajalakshmi S


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]