This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PING][PATCH v10 0/5][BZ 10871] Month names in alternative grammatical case
- From: Rafal Luzynski <digitalfreak at lingonborough dot com>
- To: libc-alpha at sourceware dot org
- Date: Thu, 30 Nov 2017 12:37:27 +0100 (CET)
- Subject: [PING][PATCH v10 0/5][BZ 10871] Month names in alternative grammatical case
- Authentication-results: sourceware.org; auth=none
- References: <1189960723.80684.1510832590965@poczta.nazwa.pl>
- Reply-to: Rafal Luzynski <digitalfreak at lingonborough dot com>
16.11.2017 12:43 Rafal Luzynski <digitalfreak@lingonborough.com> wrote:
>
>
> This is the 10th version of my patches, this time with a hope that
> it may be the final version, hence no more "RFC" tag in the subject.
> But, of course, the review is still needed.
>
> Changes since the previous version (v9):
>
> * The first patch of the series has been considered complete and
> loosely related with the rest therefore has been accepted and
> pushed to stable. [1]
> * Commit messages corrected.
> * ChangeLog changes removed (temporarily, actually moved to other
> patches which are not published here).
> * Fixed bug in strptime(), thanks Zack Weinberg for finding and
> fixing it.
> * Order of matching the month names in strptime() is consequent:
> basic month name, abbreviated, alternative, abbreviated alternative.
> * Some tests for strptime() added.
> * Everything rebased to the current (oh, sorry, yesterday's) master.
>
> This series publishes the patches 1, 3, and 5. These patches are skipped:
>
> 0002 Regenerate locfile-kw.h + ChangeLog to the previous commit (bug 10871).
> 0004 Again regenerate locfile-kw.h + ChangeLog to the previous commit (bug
> 10871).
>
> They contain the changes to the automatically generated files and
> should be eventually merged into the patches 1 and 3, respectively,
> before pushing to the git repo but should not be reviewed here.
> For those who want to examine, they are available in bugzilla [2]
> and my github repo. [3] Also note that in order to actually see
> any difference you also need the locale data which are not here
> but also in bugzilla and github. Unfortunately, my COPR repo [4]
> is not updated this time, this means that the packages in the main
> Fedora repositories are more recent and will overwrite my packages.
>
> Again, note that the backward compatibility patches which may be
> still around most probably will be rejected.
>
> Regards,
>
> Rafal
>
>
> [1] https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=f301e53
> [2] https://sourceware.org/bugzilla/show_bug.cgi?id=10871
> [3] https://github.com/rluzynski/glibc
> [4] https://copr.fedorainfracloud.org/coprs/rluzynski/genitive/
PING - any feedback about it? Currently my biggest concern is the
documentation, changelog and commit messages. I hope that the
code itself is correct (but a review is still welcome).
Also I'd like to notify that we have discussed this with the Polish
translator and the Polish locale [5] [6] will be updated with
alternative month names as soon as these patches are pushed.
For other locales at least I'd like to try to contact translators.
Regards,
Rafal
[5] https://sourceware.org/bugzilla/show_bug.cgi?id=10871#c119
[6] https://github.com/rluzynski/glibc/blob/master/localedata/locales/pl_PL