This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] localedata: Reorganize Unicode LC_CTYPE inclusion.
On 10/31/2017 03:11 PM, Rafal Luzynski wrote:
> 31.10.2017 22:54 Carlos O'Donell <carlos@redhat.com> wrote:
>>
>> [...]
>> LGTM.
>>
>> For ChangeLog would just say:
>>
>> * localedata/unicode-gen/gen_unicode_ctype.py (output_head):
>> category of LC_CTYPE set to "i18n:2012".
>> * localedata/locales/i18n_ctype: Regenerate.
>>
>> Note: "category" on line 2 need not line up with "localedata", and
>> for a regenerated file we just say "Regenerate."
>
> Thank you, Carlos, and thank you, Mike. [1] Should I add
> "Reviewed-by: Carlos O'Donell" and/or "Reviewed-by: Mike Fabian"
> to the commit message?
You should not add it unless given.
I'll give mine here :-)
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
--
Cheers,
Carlos.