This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] i586: Use a jump table in strcpy.S {BZ #22353]
- From: Florian Weimer <fweimer at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 30 Oct 2017 12:18:37 +0100
- Subject: Re: [PATCH] i586: Use a jump table in strcpy.S {BZ #22353]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 61687FED0
- References: <20171027210714.GA15539@gmail.com>
On 10/27/2017 11:07 PM, H.J. Lu wrote:
This may fail if there are instruction changes before L(1):. This patch
replaces it with a jump table which works with any instruction changes.
I think you should say instruction *length* changes.
What's the performance impact of the change? Is it even worth to use a
jump table here?
Thanks,
Florian