Re: [PATCH] localedata: Reorganize Unicode LC_CTYPE inclusion.

[Rafal Luzynski <digitalfreak at lingonborough dot com>]

25.10.2017 18:21 Carlos O'Donell <carlos@redhat.com> wrote:
>
>
> On 10/25/2017 03:03 AM, Rafal Luzynski wrote:
> > 24.10.2017 00:33 Carlos O'Donell <carlos@redhat.com> wrote:
> >> On 10/23/2017 03:21 AM, Rafal Luzynski wrote:
> >>> I will appreciate if you fix these problem on your own, the last problem
> >>> at least.
> >>
> >> I will fix this immediately and commit the changes. Thank you again for the
> >> review.
> >
> > I can't see your commit. Please do these changes or ask other people
> > (including me, of course).
>
> Committed. Just needed to test a few more things. My apologies for the delay.

Thank you.

> I'm happy to review any patches that fix mistakes I've made, please don't
> feel that you need to wait for me either. As a subsystem maintainer you can
> post a patch with "[committed]" status that fixes my mistakes, and you may
> do so immediately :-)

OK, I'll be braver next time.

However, I see that the patch you have committed [1] is different from
the patch you have proposed. [2] All those "category" lines are still
there, also "category ...;LC_TYPE" line appears twice. Can we remove them?
What do you think about the attached patch? Sorry, I'm not sure so I need
a review this time.

Regards,

Rafal


[1] https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=337ff3c
[2] https://sourceware.org/ml/libc-alpha/2017-10/msg01104.html

From 4f89944a5e28aab70a0b9387d03f6560b2fc1636 Mon Sep 17 00:00:00 2001
From: Rafal Luzynski <digitalfreak@lingonborough.com>
Date: Thu, 26 Oct 2017 22:12:23 +0200
Subject: [PATCH] localedata: Once again regenerate i18n_ctype.

Following the previous work by Carlos O'Donell the file is once again
regenerated from scratch to make sure it does not contain any manual
additions except the copyright message.

	* localedata/locales/i18n_ctype: Regenerated from scratch.
---
 localedata/locales/i18n_ctype | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/localedata/locales/i18n_ctype b/localedata/locales/i18n_ctype
index b965563..a4ecc65 100644
--- a/localedata/locales/i18n_ctype
+++ b/localedata/locales/i18n_ctype
@@ -28,18 +28,6 @@ territory "Earth"
 revision  "10.0.0"
 date      "2017-10-23"
 category  "unicode:2014";LC_CTYPE
-
-category "i18n:2012";LC_IDENTIFICATION
-category "i18n:2012";LC_CTYPE
-category "i18n:2012";LC_COLLATE
-category "i18n:2012";LC_TIME
-category "i18n:2012";LC_NUMERIC
-category "i18n:2012";LC_MONETARY
-category "i18n:2012";LC_MESSAGES
-category "i18n:2012";LC_PAPER
-category "i18n:2012";LC_NAME
-category "i18n:2012";LC_ADDRESS
-category "i18n:2012";LC_TELEPHONE
 END LC_IDENTIFICATION
 
 LC_CTYPE
-- 
2.7.5