This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: _ATFILE_SOURCE Obsoletion
- From: Carlos O'Donell <carlos at redhat dot com>
- To: mtk dot manpages at gmail dot com, Rical Jasan <ricaljasan at pacific dot net>
- Cc: Andreas Schwab <schwab at suse dot de>, Joseph Myers <joseph at codesourcery dot com>, libc-alpha <libc-alpha at sourceware dot org>, Zack Weinberg <zackw at panix dot com>
- Date: Wed, 18 Oct 2017 10:33:20 -0700
- Subject: Re: _ATFILE_SOURCE Obsoletion
- Authentication-results: sourceware.org; auth=none
- References: <e960475e-bde6-0a05-496a-35ae1cf95892@pacific.net> <mvm60bc4wt5.fsf@suse.de> <5c341bc2-bde3-1762-802a-a09c28b4ee63@pacific.net> <CAKgNAki=X=iQZzwQnYwiWf7SMig-pe+oQwuJ6zg-UYHypvibdg@mail.gmail.com>
On 10/18/2017 07:34 AM, Michael Kerrisk (man-pages) wrote:
> Also, broadening the meaning of _ATFILE_SOURCE to imply
> _POSIX_C_SOURCE==200809L sems a little risky to me, in terms of
> possibly creating developer pain.
That risk is balanced against the *removal* of _ATFILE_SOURCE,
which would mean fixing a lot of now broken packages that don't
build. Those packages would have to evaluate what needs to change,
find that they need to use _POSIX_C_SOURCE, at that point they
would have made a change which is equivalent to the deprecation
practice of defining the macro the superset feature but with a
warning.
I feel we are better serving our users by doing what has become
standard practice, as Joseph suggests, which is to map the macro
to the supported superset feature.
The only counter-argument could be that such a change is so
destructively, and silently harmful, that developers need to do
the transition manually and review all uses.
--
Cheers,
Carlos.