This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] localedef: Add --no-warnings/--warnings option
- From: Andreas Schwab <schwab at suse dot de>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, Florian Weimer <fweimer at redhat dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>
- Date: Tue, 17 Oct 2017 11:14:30 +0200
- Subject: Re: [PATCH] localedef: Add --no-warnings/--warnings option
- Authentication-results: sourceware.org; auth=none
- References: <bb4902fd-604e-2788-f7c8-742400cd6216@redhat.com>
On Okt 17 2017, Carlos O'Donell <carlos@redhat.com> wrote:
> diff --git a/locale/programs/charmap.h b/locale/programs/charmap.h
> index 5d6b48f..441d429 100644
> --- a/locale/programs/charmap.h
> +++ b/locale/programs/charmap.h
> @@ -66,6 +66,8 @@ struct charseq
>
> /* True if the encoding is not ASCII compatible. */
> extern bool enc_not_ascii_compatible;
> +/* True if the ASCII compatibility check should raise a warning. */
> +bool warn_ascii;
This should be extern.
I think both flags should be declared in the same header, since they are
defined in the same source file.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."