This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Resend: Add a new chapter on the dynamic linker




On Fri, Oct 13, 2017 at 3:39 PM, Joseph Myers <joseph@codesourcery.com> wrote:
On Fri, 13 Oct 2017, Ben Woodard wrote:

> > > +outside of a particular compilation unit. If you link object files
> > > +then the linker is able to find the location of referenced symbols or
> > > +functions in other compilation unit's object files, insert them into
> >
> > "units'", as you're referring to the object files of multiple compilation
> > units.
> >
>
> I don't think that you are correct about this. I intended it to be a
> possessive not a plural.

I was reading it as a possessive of a plural that ends with s (so needing
the apostrophe after the s, not before).  If it were the possessive of a
singular compilation unit, I'd expect e.g. "another" in place of "other".


I literally had to diagram out the sentence to make sense of this one. In this case, I am referring to one location and so "another" is more appropriate to agree with "object file"  rather than "object files".

> > > +Libraries are a special kind object file which include the partially
> >
> > "kind of object file".
> >
> > > +linked aggregation of many compilation unit's object files. You can
> >
> > "units'".
> >
>
> See above. Possessive.

Again, possessive of plural (here it seems clear it's possessive of a
plural not a singular compilation unit, given the "many").

This one is a possessive of a plural. 
Fixed.
  
> > > +to run the executable. The shared libraries needed by am executable or
> >
> > "an executable".
> >
>
> I disagree with this change. It breaks the agreement between the subject
> and the object

I'm correcting the "am executable".

fixed 

> I'm not sure what macros exist for different OSs that make use of glibc and
> how much I can say here that applies to everything. Are you saying $ORIGIN
> is universal? Are there more things are and need documenting?

$ORIGIN is nothing to do with the operating system.  It's implemented in
OS-independent code in glibc, not in OS-specific code (though OS-specific
glibc code should still be documented in the glibc manual) and not in the
kernel.  Likewise $PLATFORM and $LIB.  (The setting of dl_platform values
is generally architecture-specific not OS-specific.)

TODO. along with copy relocations

--
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]