Re: [PATCH][malloc] Improve malloc initialization sequence

[Florian Weimer <fweimer at redhat dot com>]

On 10/12/2017 03:45 PM, Andreas Schwab wrote:
> On Okt 12 2017, Florian Weimer <fweimer@redhat.com> wrote:
>
> > On 10/03/2017 07:18 PM, Wilco Dijkstra wrote:
> > > GLIBC builds and tests pass, OK for commit?
> >
> > The patch was truncated before being attached, it ends with:
> >
> > @@ -5137,11 +5114,13 @@ __libc_mallopt (int param_number, int value)
> >     if (__malloc_initialized < 0)
> >       ptmalloc_init ();
> >     __libc_lock_lock (av->mutex);
> > -  /* Ensure initialization/consolidation */
> > -  malloc_consolidate (av);
> > =20
> >     LIBC_PROBE (memory_mallopt, 2, param_number, value);
> > =20
> > +  /* We must consolidate main arena before changing max_fast
> > +     (see definition of set_max_fast).  */
> > +  malloc_consolidate (av);
> > +
> >     switch (param_number)
> >       {
> >       case M_MXFAST:=
> >
> > This is not a valid diff hunk (after quoted-printable decoding).
>
> Looks ok to me (9 lines of context, 2-, 4+).

The = masks the final newline, so you end up with a diff hunk that 
doesn't have a newline on the last line.  But the file clearly goes on 
after this, so this isn't valid.  And even if it did not, there would be 
a “\ No newline at end of file” marker.

Thanks,
Florian