This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] nscd: remove reference to libnsl
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>, libc-alpha at sourceware dot org
- Date: Wed, 11 Oct 2017 06:29:34 -0700
- Subject: Re: [PATCH] nscd: remove reference to libnsl
- Authentication-results: sourceware.org; auth=none
- References: <mvmmv4yxdoz.fsf@suse.de>
On 10/11/2017 01:59 AM, Andreas Schwab wrote:
> This removes the dependency on libnsl from nscd. It only used __nis_hash,
> build its own copy under the name __nscd_hash.
>
> * nis/Makefile (aux): Remove.
> * nscd/Makefile (aux): Add nscd_hash.
> (nscd-modules): Likewise.
> ($(objpfx)nscd): Don't depend on libnsl.
> * nscd/nscd_hash.c: New file.
> * nscd/nscd_hash.h: Likewise.
> * nscd/cache.c: Include "nscd_hash.h" instead of <rpcsvc/nis.h>.
> (cache_search, cache_add): Use __nscd_hash instead of __nis_hash.
> * nscd/nscd_helper.c: Include <sys/param.h> and "nscd_hash.h"
> instead of <nis/rpcsvc/nis.h>.
> (__nscd_cache_search): Use __nscd_hash instead of __nis_hash.
LGTM.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
--
Cheers,
Carlos.