This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 1/3] Optimized sincosf

On Mon, 9 Oct 2017, Rajalakshmi Srinivasaraghavan wrote:

> +/* Chebyshev constants for sin & cos, range -PI/4 - PI/4.  */
> +static const double C0 = -0x1.ffffffffe98ae000p-2;

I don't think the trailing 000 on all the double constants makes sense.

> +static const double invpio4_table[] = {

This table looks a lot bigger than should actually be needed for float 
range reduction (you can determine how close a float can get to a nonzero 
integer multiple of pi/2 using continued fractions).

-- 
Joseph S. Myers
joseph@codesourcery.com
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]