This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Move nss_compat from nis to nss subdir and install it unconditionally.
- From: Florian Weimer <fweimer at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>, Zack Weinberg <zackw at panix dot com>
- Cc: Yury Norov <ynorov at caviumnetworks dot com>, GNU C Library <libc-alpha at sourceware dot org>, Steve dot Ellcey at cavium dot com, maxim dot kuvyrkov at linaro dot org
- Date: Wed, 4 Oct 2017 12:31:05 +0200
- Subject: Re: [PATCH] Move nss_compat from nis to nss subdir and install it unconditionally.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EF7F7267D8
- References: <20170927215018.6nagohfthyezs3mo@yury-thinkpad> <de59bd81-d555-b9dc-5089-2926b5a2573a@redhat.com> <20170928112847.i2hnrzr2zm66z2un@yury-thinkpad> <017aeba9-6400-6ef2-b70c-74db69b1aa39@redhat.com> <20170928122836.3srxfgn5vh5utngs@yury-thinkpad> <b4b07d46-0792-c36c-b369-69f6c5055b19@redhat.com> <CAKCAbMhvSc9D1VrXw5GTioU-s0QypA8S3KjRRcCp+hkE4BGPPg@mail.gmail.com> <b8613b22-6d6f-3f08-24af-cc2dfa5373b9@redhat.com> <CAKCAbMgTPcy9E6GRni-pzYhjMLd5h8+y2mUQVK7UyCbXkAgh1g@mail.gmail.com> <mvmo9pn5jhp.fsf_-_@suse.de>
On 10/04/2017 11:51 AM, Andreas Schwab wrote:
This has been tested that local lookup still works with and
without an installed libnss_nis, and that NIS lookup works when
libnss_nis is available.
* nis/Makefile (services): Remove compat.
(libnss_compat-routines, libnss_compat-inhibit-o): Don't define.
($(objpfx)libnss_compat.so): Remove rule.
* nis/Versions (libnss_compat): Remove.
* nss/Makefile (services): Add compat.
(libnss_compat-routines, libnss_compat-inhibit-o): Define.
* nss/Versions (libnss_compat): Define.
* nss/nss_compat/compat-grp.c: Moved here from nis/nss_compat.
Don't include <rpc/types.h>. Replace bool_t by bool.
* nss/nss_compat/compat-initgroups.c: Likewise.
* nss/nss_compat/compat-pwd.c: Likewise. Include "nisdomain.h"
instead of <rpcsrv/ypclnt.h>.
(getpwent_next_nss_netgr): Use __nss_get_default_domain instead of
yp_get_default_domain.
* nss/nss_compat/compat-pwd.c: Likewise.
(getspent_next_nss_netgr): Use __nss_get_default_domain instead of
yp_get_default_domain.
* nss/nss_compat/nisdomain.c: New file.
* nss/nss_compat/nisdomain.h: Likewise.
This looks good to me. Thanks.
Florian