This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] i386: Use "movl main@GOT(%ebx), %eax" in start.S
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Florian Weimer <fw at deneb dot enyo dot de>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 3 Oct 2017 15:45:01 -0700
- Subject: Re: [PATCH] i386: Use "movl main@GOT(%ebx), %eax" in start.S
- Authentication-results: sourceware.org; auth=none
- References: <20171003141916.GA8915@gmail.com> <87efqkqm3j.fsf@mid.deneb.enyo.de>
On 10/3/17, Florian Weimer <fw@deneb.enyo.de> wrote:
> * H. J. Lu:
>
>> Don't use "leal main@GOTOFF(%ebx), %eax" since main may be in a
>> shared object. Linker will convert "movl main@GOT(%ebx), %eax"
>> to "leal main@GOTOFF(%ebx), %eax" if main is defined locally.
>>
>> Any comments?
>
> Would it be worthwhile to add a test for this which is not
> architecture-specific?
>
Yes, a patch is here:
https://sourceware.org/ml/libc-alpha/2017-10/msg00104.html
--
H.J.