This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] fix posix/tst-spawn test

From: Florian Weimer <fweimer at redhat dot com>
To: Szabolcs Nagy <szabolcs dot nagy at arm dot com>, GNU C Library <libc-alpha at sourceware dot org>
Cc: nd at arm dot com
Date: Wed, 27 Sep 2017 16:45:23 +0200
Subject: Re: [PATCH] fix posix/tst-spawn test
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C7FD6C04D92A
References: <59CB9FFA.20307@arm.com> <491b35ff-a58c-fc94-2759-e944dceb8f3d@redhat.com> <59CBB879.5060707@arm.com>

On 09/27/2017 04:40 PM, Szabolcs Nagy wrote:

The test spawns two children but only waited for one.
The fix avoids printing to stderr.

2017-09-27  Szabolcs Nagy<szabolcs.nagy@arm.com>

	* posix/tst-spawn.c (do_test): Wait for both children.

Sorry, one more thing: I think you should not interleave the spawns andwaits. I think you can do a -1 wait after the PID wait, and the testwill still pass. This should be closer to the original test.


Thanks,
Florian

Follow-Ups:
- Re: [PATCH] fix posix/tst-spawn test
  - From: Szabolcs Nagy

References:
- [PATCH] fix posix/tst-spawn test
  - From: Szabolcs Nagy
- Re: [PATCH] fix posix/tst-spawn test
  - From: Florian Weimer
- Re: [PATCH] fix posix/tst-spawn test
  - From: Szabolcs Nagy

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]