This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Simplify C99 isgreater macros
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, nd <nd at arm dot com>
- Date: Tue, 26 Sep 2017 17:20:31 +0000
- Subject: Re: [PATCH] Simplify C99 isgreater macros
- Authentication-results: sourceware.org; auth=none
- References: <DB6PR0801MB2053C6E4E6A4A462BD4919D9837B0@DB6PR0801MB2053.eurprd08.prod.outlook.com>
On Tue, 26 Sep 2017, Wilco Dijkstra wrote:
> Simplify the C99 isgreater macros. Although some support was added
> in GCC 2.97, not all targets added support until GCC 3.1. Therefore
> only use the builtins in math.h from GCC 3.1 onwards, and defer to
> generic macros otherwise. Improve the generic isunordered macro
> to use compares rather than call fpclassify twice - this is not only faster
> but also correct for signaling NaNs.
>
> OK for commit?
OK if compilation has been tested for at least one configuration using
each changed header, with or without fixes for the pre-existing formatting
bugs (missing space before '(' in calls to __GNUC_PREREQ, __builtin_* and
__typeof__).
--
Joseph S. Myers
joseph@codesourcery.com