This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix for bz14333 -- race between atexit() and exit()

From: Joseph Myers <joseph at codesourcery dot com>
To: Carlos O'Donell <carlos at redhat dot com>
Cc: Paul Pluzhnikov <ppluzhnikov at google dot com>, Torvald Riegel <triegel at redhat dot com>, Andreas Schwab <schwab at suse dot de>, GLIBC Devel <libc-alpha at sourceware dot org>, Ricky Zhou <rickyz at google dot com>
Date: Wed, 20 Sep 2017 16:50:58 +0000
Subject: Re: [patch] Fix for bz14333 -- race between atexit() and exit()
Authentication-results: sourceware.org; auth=none
References: <CALoOobNCZqgvcLJhuJt5eSWseuTfHJ9oVsG9TpPvytyfzF56mg@mail.gmail.com> <CALoOobMnZ=dE52uWT-PXSb+Sz8SRbjG7FKCmuG+kZ47db76PUg@mail.gmail.com> <1500467179.27895.55.camel@redhat.com> <CALoOobPx5KHn7rGQKTy3UnEq_YnzXnGKrKCLmJHPd5bkipb79g@mail.gmail.com> <1500926864.30433.42.camel@redhat.com> <CALoOobO1sCK2jMJ69_r-m47PshpM3OnReWkAp6QA=vr6OycrJw@mail.gmail.com> <CALoOobPuWkBOjqMnb9OWf1-3G4=vXqL_Z0LTs7HWACn=Ew+mng@mail.gmail.com> <abd5aba0-4ffe-4794-f390-d57b1522b937@redhat.com> <CALoOobP4KGou=4OL7hVEDOTPesUyNnZE4CoaRhJCCU=RBGPyQQ@mail.gmail.com> <d4b7473f-92eb-db93-7b74-edc4805acffd@redhat.com> <CALoOobM=EkhzY9ye0bsGfFqqfz2kHGV10oJpER3ey_bMCNCj1A@mail.gmail.com> <2d7b1ff8-a87e-657d-4047-57ea99d40918@redhat.com> <CALoOobPPjvPWrngw4iYwuSfs2drPPEhyANvUt8YbO2QvkJiBvw@mail.gmail.com> <6f5edc0d-ede5-d9d3-4c26-3776fd5c41ff@redhat.com> <CALoOobP0UuvjrG_8bz2xWFeRZoV7n1qEG=WwifUgNGaoOqoKig@mail.gmail.com> <ae6fd90c-39e4-d7b3-c08d-3a1387fd7a9c@redhat.com>

I note the commit message just said "Fix BZ 14333".  Can people please 
include the more detailed descriptions of changes made, as in their 
mailing list postings, in the commit message?  There are certainly some 
simple changes for which just a summary line is sufficient explanation, 
but I don't think this was such a change.  Descriptive commit messages are 
especially important if we stop using ChangeLog entries in future.

(This does mean it's good practice, when making a series of revisions of a 
patch, for each successive revision to have both the full self-contained 
explanation, updated for that patch revision, such as would go in the 
commit message, and a description of what changed from the previous patch 
version, which won't go in the commit message.)

-- 
Joseph S. Myers
joseph@codesourcery.com

Follow-Ups:
- Re: [patch] Fix for bz14333 -- race between atexit() and exit()
  - From: Carlos O'Donell

References:
- Re: [patch] Fix for bz14333 -- race between atexit() and exit()
  - From: Carlos O'Donell
- Re: [patch] Fix for bz14333 -- race between atexit() and exit()
  - From: Paul Pluzhnikov
- Re: [patch] Fix for bz14333 -- race between atexit() and exit()
  - From: Carlos O'Donell
- Re: [patch] Fix for bz14333 -- race between atexit() and exit()
  - From: Paul Pluzhnikov
- Re: [patch] Fix for bz14333 -- race between atexit() and exit()
  - From: Carlos O'Donell
- Re: [patch] Fix for bz14333 -- race between atexit() and exit()
  - From: Paul Pluzhnikov
- Re: [patch] Fix for bz14333 -- race between atexit() and exit()
  - From: Carlos O'Donell
- Re: [patch] Fix for bz14333 -- race between atexit() and exit()
  - From: Paul Pluzhnikov
- Re: [patch] Fix for bz14333 -- race between atexit() and exit()
  - From: Carlos O'Donell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]