This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/2] Use C11 _Alignas on scratch_buffer internal buffer

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
Date: Mon, 18 Sep 2017 09:10:47 -0700
Subject: Re: [PATCH 2/2] Use C11 _Alignas on scratch_buffer internal buffer
Authentication-results: sourceware.org; auth=none
References: <1505745774-29303-1-git-send-email-adhemerval.zanella@linaro.org> <1505745774-29303-2-git-send-email-adhemerval.zanella@linaro.org>

This patch could cause problems on non-GCC platforms. According to the Gnulibdocumentation<https://www.gnu.org/software/gnulib/manual/html_node/stdalign_002eh.html>, SunC 5.11 supports _Alignas but not on auto variables. In practice, the unpatchedscratch_buffer.h uses 1024-byte buffers everywhere, so the initial buffer sizewill be in sync on all platforms even without the patch. Since the patch addscomplexity, seems to have no technical advantage, and has potential downsides, Isuggest leaving that part of scratch_buffer.h alone.

Follow-Ups:
- Re: [PATCH 2/2] Use C11 _Alignas on scratch_buffer internal buffer
  - From: Florian Weimer

References:
- [PATCH v2 1/2] posix: Add compat glob symbol to not follow dangling symbols
  - From: Adhemerval Zanella
- [PATCH 2/2] Use C11 _Alignas on scratch_buffer internal buffer
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]