Re: [PATCH 7/9] posix: Consolidate glob implementation

[Adhemerval Zanella <adhemerval dot zanella at linaro dot org>]

On 12/09/2017 04:35, Andreas Schwab wrote:
> On Sep 05 2017, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
> 
>>   * On Linux all implementation now uses a default one with the exception
>>     of alpha (which requires specific versioning) and s390-32 (which
>>     different than other 32 bits with support for v2.1 symbol does not
>>     add a compat one).
> 
> This drops the default glob64 symbol from s390 (the glob64@GLIBC_2.1
> symbol is now hidden).
> 
> Andreas.
> 

That was not what I am seeing from master:

$ file libc.so
libc.so: ELF 32-bit MSB shared object, IBM S/390, version 1 (GNU/Linux), dynamically linked, interpreter /lib/ld.so.1, for GNU/Linux 3.2.0, not stripped
$ s390x-glibc-linux-gnu-objdump -t libc.so | grep glob64
00000000 l    df *ABS*  00000000              glob64.os
001221c8 l     F .text  0000144e              __GI___old_glob64
000b3330 l     F .text  0000144e              glob64
000b3330 l     F .text  0000144e              __GI_glob64
000b3330 l     F .text  0000144e              __glob64
001221c8 l     F .text  0000144e              __old_glob64
001221c8 g     F .text  0000144e              glob64@GLIBC_2.1

And checking the build of glob64.os for s390 I do see:

[...]
extern __typeof (__glob64) glob64 __attribute__ ((alias ("__glob64")));
extern __typeof (glob64) __EI_glob64 __asm__("" "glob64"); extern __typeof (glob64) __EI_glob64 __attribute__((alias ("" "__GI_glob64")));
[...]

$ s390x-glibc-linux-gnu-objdump -t posix/glob64.os | grep glob64
posix/glob64.os:     file format elf32-s390
000009b0 g     F .text  0000144e __glob64
000009b0 g     F .text  0000144e .hidden __GI_glob64
000009b0 g     F .text  0000144e glob64

And make check/check-abi does not report this issue as well.  That kind of issue
should be reported by make check-abi, shouldn't it? Are you seeing with on 
make check?