This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Make copy of <bits/std_abs.h> from GCC 7 [BZ #21573]
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Florian Weimer <fweimer at redhat dot com>, Libc-stable Mailing List <libc-stable at sourceware dot org>
- Cc: Andreas Schwab <schwab at suse dot de>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 11 Sep 2017 08:53:51 -0700
- Subject: Re: [PATCH] Make copy of <bits/std_abs.h> from GCC 7 [BZ #21573]
- Authentication-results: sourceware.org; auth=none
- References: <20170613113813.GA7656@gmail.com> <mvm4lvkktdq.fsf@suse.de> <CAMe9rOp-VNbKJJhvBwT12OJ0Qcu2_DMhKEH855GOpA9CsZcZ3w@mail.gmail.com> <mvmzidcjekn.fsf@suse.de> <CAMe9rOoXF7-40n-n7z8JdNeyc6CBPYk1AeK73KT_pmBvDdxAcQ@mail.gmail.com> <230d2cab-8085-bb7e-68cc-38de409397a7@redhat.com> <CAMe9rOpfGr_BNFB3k5Dw3h_a=jnBrQL_e44y_+Zc8gzw16a+9A@mail.gmail.com> <CAMe9rOqAf23yuz7U-7P2NfJuX5j74wdbVfncpnXMyp2-ZHYrXg@mail.gmail.com>
On Thu, Sep 7, 2017 at 10:26 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Tue, Jun 13, 2017 at 1:21 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Tue, Jun 13, 2017 at 1:13 PM, Florian Weimer <fweimer@redhat.com> wrote:
>>> On 06/13/2017 01:54 PM, H.J. Lu wrote:
>>>> - echo "#include <$1>" | $CXX -M -MP -x c++ - | sed -n "/$1:/{s/:\$//;p}"
>>>> + echo "#include <$1>" | $CXX -M -MP -x c++ - | sed -n "\,$1:,{s/:\$//;p}"
>>>> }
>>>> CXX_CSTDLIB_HEADER="$(find_cxx_header cstdlib)"
>>>> + # Also make a copy of <bits/std_abs.h> from GCC 7 to prevent it from
>>>> + # including /usr/include/stdlib.h.
>>>> + CXX_CSTDLIB_HEADER="$CXX_CSTDLIB_HEADER $(find_cxx_header bits/std_abs.h)"
>>>
>>> I think the attached patch is needed to suppress the error message if
>>> the header does not exist. (Regenerated configure file not shown in the
>>> patch.)
>>>
>>
>> LGTM.
>>
>
> Here is a patch to backport these 2 patches to 2.25 branch. Any
> comments?
>
I am checking it into 2.25 branch.
--
H.J.