This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC PATCH 00/52] Make GLIBC Y2038-proof


General observations on this patch series:

* Nothing should use a GLIBC_Y2038 version.  Use GLIBC_2.27 and update as 
necessary during rebases if this doesn't get into 2.27.

* Nothing should go in architecture-specific files such as 
sysdeps/unix/sysv/linux/arm/Versions.  For OS-independent interfaces use 
files such as time/Versions - wherever the existing versions of those 
interfaces for existing time_t are.

* How such a patch series was tested needs to be described in the summary 
of the series.  For a series like this, full testsuite runs on multiple 
32-bit and 64-bit architectures as well as use of build-many-glibcs.py to 
do the compilation tests for (almost) all configurations is important (or 
if a series is a preliminary version with limited architecture support, 
that should be stated explicitly, but the full testsuite should still pass 
on at least one 32-bit and one 64-bit architecture).

* I'd expect lots of extra tests using _TIME_BITS=64 to be added in such a 
patch series, to make sure that every new ABI is covered by the testsuite.

* Documentation of _TIME_BITS is clearly needed.

* You need to make sure that new ABIs are not added / used on platforms 
where time_t is already 64-bit.

* All new files need a descriptive first line before the copyright notice.

* All copyright ranges in new files should end with 2017.

* No "Contributed by" in new files.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]