This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Silence -O3 -Wall warning in malloc/hooks.c with GCC 7 [BZ #22052]
- From: Florian Weimer <fweimer at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Carlos O'Donell <carlos at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 4 Sep 2017 10:33:48 +0200
- Subject: Re: [PATCH] Silence -O3 -Wall warning in malloc/hooks.c with GCC 7 [BZ #22052]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D1294C0587F8
- References: <CAMe9rOqvpS_HH6_k=rPuE3qx6oifjL8_WKzTVFhK9eZs84NvFA@mail.gmail.com>
On 09/03/2017 05:48 PM, H.J. Lu wrote:
> + unsigned char *magic_p = NULL;
I think the current practice is to use <libc-diag.h> to suppress the
warning.
Is the issue that the memory clobber on the inline asm makes GCC not to
see the conditional initialization?
Thanks,
Florian