This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [hurd,commited] hurd: Fix build ot misc/tst-preadvwritev2-common.c
- From: Florian Weimer <fweimer at redhat dot com>
- To: Samuel Thibault <samuel dot thibault at ens-lyon dot org>, libc-alpha at sourceware dot org
- Date: Mon, 4 Sep 2017 10:11:32 +0200
- Subject: Re: [hurd,commited] hurd: Fix build ot misc/tst-preadvwritev2-common.c
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AA50180461
- References: <20170903155209.3911-1-samuel.thibault@ens-lyon.org>
On 09/03/2017 05:52 PM, Samuel Thibault wrote:
> + * misc/tst-preadvwritev2-common.c (RWF_HIPRI, RWF_DSYNC, RWF_SYNC,
> + RWF_NOWAIT): Define to 0 if undefined already.
> + (do_test_with_invalid_flags): Set invalid_flag to 2 if RWF_SUPPORTED
> + boils down to 0.
I don't think this is correct. preadv2 etc. are supposed to be part of
the GNU API, so if Hurd doesn't have definitions of the WRF_* constants,
that's a real bug.
Thanks,
Florian