This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 24/58] Hide __chmod and __mkdir [BZ #18822]
- From: Florian Weimer <fweimer at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>, libc-alpha at sourceware dot org
- Date: Mon, 4 Sep 2017 10:02:05 +0200
- Subject: Re: [PATCH 24/58] Hide __chmod and __mkdir [BZ #18822]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B01AC81E1A
- References: <20170901180029.9527-1-hjl.tools@gmail.com> <20170901180029.9527-25-hjl.tools@gmail.com>
On 09/01/2017 07:59 PM, H.J. Lu wrote:
> Hide internal __chmod and __mkdir functions to allow direct access
> within libc.so and libc.a without using GOT nor PLT.
>
> [BZ #18822]
> * include/sys/stat.h (__chmod): Add libc_hidden_proto.
> (__mkdir): Likewise.
> * io/chmod.c (__chmod): Add libc_hidden_def.
> * io/mkdir.c (__mkdir): Likewise.
> * sysdeps/mach/hurd/chmod.c (__chmod): Likewise.
> * sysdeps/mach/hurd/mkdir.c (__mkdir): Likewise.
> * sysdeps/unix/sysv/linux/generic/chmod.c (__chmod): Likewise.
> * sysdeps/unix/sysv/linux/generic/mkdir.c (__mkdir): Likewise.
Looks good to me.
Thanks,
Florian