This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 19/58] Mark internal stdlib functions with attribute_hidden [BZ #18822]
- From: Florian Weimer <fweimer at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>, libc-alpha at sourceware dot org
- Date: Sun, 3 Sep 2017 11:13:17 +0200
- Subject: Re: [PATCH 19/58] Mark internal stdlib functions with attribute_hidden [BZ #18822]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E70B4C0587C5
- References: <20170901180029.9527-1-hjl.tools@gmail.com> <20170901180029.9527-20-hjl.tools@gmail.com>
On 09/01/2017 07:59 PM, H.J. Lu wrote:
> (__qecvt_r): Likewise.
> (__qfcvt_r): Likewise.
I think this change makes symbols vanish from the public ABI on various
architectures:
--- ../sysdeps/unix/sysv/linux/powerpc/powerpc64/libc.abilist
2017-08-28 05:01:14.557643019 -0400
+++ /home/bmg/build/glibcs/powerpc64-linux-gnu/glibc/libc.symlist
2017-09-03 05:07:32.110128081 -0400
@@ -1383 +1382,0 @@ GLIBC_2.3 qecvt F
-GLIBC_2.3 qecvt_r F
@@ -1385 +1383,0 @@ GLIBC_2.3 qfcvt F
-GLIBC_2.3 qfcvt_r F
@@ -2198 +2195,0 @@ GLIBC_2.4 qecvt F
-GLIBC_2.4 qecvt_r F
@@ -2200 +2196,0 @@ GLIBC_2.4 qfcvt F
-GLIBC_2.4 qfcvt_r F
(I assume that the patch is identical to what is on the hjl/pr18822
branch, which is what I used for testing.)
Thanks,
Florian