This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 08/58] Mark __dso_handle as hidden [BZ #18822]
- From: Florian Weimer <fweimer at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>, libc-alpha at sourceware dot org
- Date: Sun, 3 Sep 2017 11:11:37 +0200
- Subject: Re: [PATCH 08/58] Mark __dso_handle as hidden [BZ #18822]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 29A265F73C
- References: <20170901180029.9527-1-hjl.tools@gmail.com> <20170901180029.9527-9-hjl.tools@gmail.com> <0939b71c-f05e-cfef-0499-9912bc82f49a@redhat.com>
On 09/03/2017 10:21 AM, Florian Weimer wrote:
> On 09/01/2017 07:59 PM, H.J. Lu wrote:
>> diff --git a/include/stdlib.h b/include/stdlib.h
>> index 2274790a2e..d0dcbf81c3 100644
>> --- a/include/stdlib.h
>> +++ b/include/stdlib.h
>> @@ -5,6 +5,10 @@
>> #endif
>> #include <stdlib/stdlib.h>
>>
>> +/* __dso_handle is always defined by either crtbegin.o from GCC or our
>> + dso_handle.c. */
>> +extern void *__dso_handle __attribute__ ((visibility ("hidden")));
>
> This causes conform test failures. You need to use __visibility__ here.
Or alternatively, move the declaration under #ifndef _ISOMAC. That's
probably the better approach because __dso_handle is not part of the
installed headers.
Thanks,
Florian