This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix tests that are testing obsoleted functionality
- From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- To: sellcey at cavium dot com, Carlos O'Donell <carlos at redhat dot com>, libc-alpha <libc-alpha at sourceware dot org>
- Cc: nd at arm dot com, Florian Weimer <fweimer at redhat dot com>, Joseph Myers <joseph at codesourcery dot com>
- Date: Fri, 01 Sep 2017 18:13:51 +0100
- Subject: Re: [PATCH] Fix tests that are testing obsoleted functionality
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs dot Nagy at arm dot com;
- Nodisclaimer: True
- References: <1503615332.28672.106.camel@cavium.com> <6025886b-14ab-f188-a2f6-5d5855097efd@redhat.com> <1503950888.28672.136.camel@cavium.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 28/08/17 21:08, Steve Ellcey wrote:
> On Thu, 2017-08-24 at 19:11 -0400, Carlos O'Donell wrote:
>>
>> From a high-level perspective this looks good to me.
>>
>> I know we're not supposed to do anything special on master for
>> AArch64 ILP32, but this kind of generic cleanup that future-proofs
>> the test for new arches (we are expecting RISC-V port to turn
>> up soon and they would have seen this) is a win win.
>>
>> I'd like one other developer to ACK before you commit this, since
>> I'd like to hear a few more opinions on how we might handle this.
>
> Any other comments on this? Any objections to the patch?
>
while you wait for feedback on master,
i committed the current patch to arm/ilp32
since it is needed for clean tests there.
(i'm still not decided on what's the best
way to manage the branch, i plan to do
rebases and then such commits can be
dropped if master have them too, but i'm
open to feedback if there are issues with
rebasing public branches.)