This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] malloc: Remove corrupt arena flag
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
- Date: Wed, 30 Aug 2017 11:31:25 -0500
- Subject: Re: [PATCH] malloc: Remove corrupt arena flag
- Authentication-results: sourceware.org; auth=none
- References: <20170830160422.F2F1540C0E092@oldenburg.str.redhat.com>
On 08/30/2017 11:04 AM, Florian Weimer wrote:
> This is no longer needed because we now abort immediately
> once heap corruption is detected.
>
> 2017-08-30 Florian Weimer <fweimer@redhat.com>
>
> * malloc/malloc.c (ARENA_CORRUPTION_BIT, arena_is_corrupt)
> (set_arena_corrupt): Remove definitions.
> (mtrim): Do not check for corrupt arena.
> * malloc/arena.c (arena_lock, reused_arena, arena_get_retry):
> Likewise.
Thanks for getting to the point where we can remove this.
Less code in the allocator is always better.
Patch looks good to me.
--
Cheers,
Carlos.