This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] have ifunc resolver's return type match target
- From: Florian Weimer <fweimer at redhat dot com>
- To: Martin Sebor <msebor at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 23 Aug 2017 11:28:51 +0200
- Subject: Re: [PATCH] have ifunc resolver's return type match target
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EAF147EA8A
- References: <f967b8f5-6802-f848-ba68-b1df8069d379@gmail.com>
On 08/21/2017 12:30 AM, Martin Sebor wrote:
> The following GCC patch has been submitted for review. It
> helps detect mismatches between the type of an ifunc or alias
> declaration and the type of the resolver or alias.
>
> https://gcc.gnu.org/ml/gcc-patches/2017-08/msg01103.html
>
> To let Glibc take advantage of this type checking and avoid
> warnings when using the patched GCC when the change above is
> committed, the patch below adjusts the Glibc __ifunc_resolver
> macro to declare the ifunc resolver so that its return type
> matches that of the target. (I was going to wait to submit it
> until after the GCC patch has been accepted but per Joseph's
> suggestion I'm posting it here ahead of time.)
Do we have to backport both patches to older releases, too, so that they
keep building with a newer GCC?
Thanks,
Florian