This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Mark internal functions with attribute_hidden

On Thu, Aug 17, 2017 at 11:57 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, Aug 17, 2017 at 7:01 AM, Joseph Myers <joseph@codesourcery.com> wrote:
>> On Thu, 17 Aug 2017, H.J. Lu wrote:
>>
>>> Yes, this is target independent.   It should benefit static PIE build for all
>>> targets.  On x86, it bypasses GOT/PLT.
>>
>> Specifically, on x86 I'd consider this (making functions hidden if they
>> are not exported from the shared library containing their definitions) to
>> be part of the fix for bug 18822.
>>
>
> You are right.  Here is the same patch with libc.so size comparison on
> i686 and x86-64.
>
> OK for trunk?
>
>

Any comments or objections?


-- 
H.J.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]