This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/3] Mark __libc_multiple_libcs with attribute_hidden [BZ #18822]
- From: Florian Weimer <fweimer at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 21 Aug 2017 12:03:19 +0200
- Subject: Re: [PATCH 1/3] Mark __libc_multiple_libcs with attribute_hidden [BZ #18822]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 75017C0587F2
- References: <20170818203021.GA15188@gmail.com> <87mv6uoes1.fsf@mid.deneb.enyo.de> <20170820141235.GA14485@gmail.com>
On 08/20/2017 04:12 PM, H.J. Lu wrote:
> +/* Set nonzero if we have to be prepared for more than one libc being
> + used in the process. */
> +extern int __libc_multiple_libcs attribute_hidden;
I think the comment gives the wrong impression. The flag is not always
set if there are multiple libcs in the process, and it certainly is not
set just because we might end up having multiple libcs in the future
(which is why the “have to be prepared” part irks me).
Thanks,
Florian