This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/4] Mark __internal_statvfs[64] with attribute_hidden [BZ #18822]
- From: Florian Weimer <fweimer at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 18 Aug 2017 15:19:20 +0200
- Subject: Re: [PATCH 2/4] Mark __internal_statvfs[64] with attribute_hidden [BZ #18822]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D5F5B4A6E6
- References: <20170817205809.GA7760@gmail.com> <1007f108-dd4f-faf8-eeea-864c2a830d2c@redhat.com> <CAMe9rOoon5y6v8HEhNc4hn-Ou=wehwiizhvg9VKzt13stcdnEw@mail.gmail.com>
On 08/18/2017 03:15 PM, H.J. Lu wrote:
> On Fri, Aug 18, 2017 at 5:55 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> On 08/17/2017 10:58 PM, H.J. Lu wrote:
>>> Mark __internal_statvfs[64] with attribute_hidden to allow direct access
>>> to them within libc.so and libc.a without using GOT nor PLT.
>>>
>>> Tested on i686 and x86-64. OK for master?
>>
>> This is a bit odd because the include/ headers are supposed to be
>> generic, and the declarations you add are Linux-specific. In the past,
>> we would have added a Linux-specific header under
>> sysdeps/unix/sysv/linux for that.
>>
>> I don't have a strong opinion either way.
>>
>
> Header files under include override both generic and non-generic header
> files. __KERNEL_STRICT_NAMES is another example.
Right. I'm sure your patch works as intended (at least on most
architectures). It's just a matter of policy to what extent we want to
uphold the fiction that upstream glibc supports more than just Linux.
Thanks,
Florian