This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Mark internal functions with attribute_hidden
- From: Florian Weimer <fweimer at redhat dot com>
- To: Zack Weinberg <zackw at panix dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 17 Aug 2017 15:34:46 +0200
- Subject: Re: [PATCH] Mark internal functions with attribute_hidden
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7F5EAC07FC03
- References: <20170817122549.GA15116@gmail.com> <6be4ed47-4eae-3bb9-73bf-0943067494f9@redhat.com> <CAMe9rOqMoQG+r6n5TfLDVFoAEAgiwhVUXx5XhaqOGhjUt-us8g@mail.gmail.com> <CAKCAbMjfq=8JNz=-aJ10MRfafDGnMf6+M2+KzSMAc+JQ5c=Syw@mail.gmail.com>
On 08/17/2017 03:12 PM, Zack Weinberg wrote:
> On Thu, Aug 17, 2017 at 8:43 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Thu, Aug 17, 2017 at 5:37 AM, Florian Weimer <fweimer@redhat.com> wrote:
>>> On 08/17/2017 02:25 PM, H.J. Lu wrote:
>>>> Mark internal functions with attribute_hidden to allow direct access to
>>>> internal functions within libc.a without using GOT when the compiler
>>>> defaults to -fPIE.
>>>
>>> This explanation is a bit confusing. I think this benefits other
>>> architectures, too.
>>
>> Yes, this is target independent. It should benefit static PIE build for all
>> targets. On x86, it bypasses GOT/PLT.
>
> Should internal_function just imply attribute_hidden? Or is this
> inappropriate for some things marked internal_function?
I want to remove internal_function completely because it serves no
useful purpose whatsoever because it has never been used consistently.
Currently, it expands to an empty string on all builds.
Thanks,
Florian