This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 00/18] posix: glob fixes and refactor
On 17/08/2017 07:19, Florian Weimer wrote:
> On 08/11/2017 04:50 PM, Adhemerval Zanella wrote:
>> I did not and will not take care of the non-unix code on glob.c (it
>> is probably broken after the glob refactor). In fact I would like
>> to cleanup this implementation even further to remove all code not
>> really used for GLIBC if gnulib developers want to not keep the
>> implementation at sync.
>
> I would prefer to de-couple from gnulib and run unifdef as a first step.
> When working on the code the last time, I had too many moments of “this
> code isn't for us, how can we keep it”.
That was my feeling as well, but my understanding was the general idea is to
keep the code compatible for future sync. However due the changes I agree
that decoupling should be a better strategy. I can update the 01/18 with
a general cleanup or adding another upcoming patch with this change, which
do you think it is better?