This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Test for profiling support (_mcount/gprof)


On 08/16/2017 11:19 PM, H.J. Lu wrote:
> -pg and -pie are mutually exclusive since they need different crt1.o,
> gcrrt1.o vs Scrt1.o.  Make -pg overrdies -pie.
> 
> 	* Makeconfig (+link-pie-before-libc): Add CRT-* hook to override
> 	the startup object.

Typo (gcrrt1.o), and the commit message is confusing.  There is no -pg
involved at the linking stage.

gcrt1.o is deliberately compiled so that it is compatible with PIE, so
the patch itself is okay.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]