This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] i386: Replace internal_function attribute for __mcount_internal
- From: Florian Weimer <fweimer at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 15 Aug 2017 14:25:48 +0200
- Subject: Re: [PATCH] i386: Replace internal_function attribute for __mcount_internal
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5EB5F2C96DE
- References: <54445c79-cdb6-27a0-5704-d13e8f888f91@redhat.com> <d2fcbeb3-2f6e-5e1c-f07f-04f850bceb40@redhat.com> <CAMe9rOrrkYikoDP7E8GProFScALiDpLgv57DPyxQqnZ9XLWvOQ@mail.gmail.com>
On 08/15/2017 02:19 PM, H.J. Lu wrote:
> On Tue, Aug 15, 2017 at 5:08 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> With the separate test patch I posted ([PATCH] Test for profiling
>> support (_mcount/gprof)), is this now okay to commit?
>>
>
> Does the new test fail without the __mcount_internal patch?
Yes, it does. The executable does not generate any profiling data:
$ cat gmon/tst-gmon-gprof.out
--- expected
+++ actual
@@ -1,2 +0,0 @@
-f1 2000
-f2 1000
FAIL
Florian