This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] manual: Update alloca and variable length array documentation
On 08/11/2017 09:28 AM, Florian Weimer wrote:
> On 08/11/2017 03:11 PM, Carlos O'Donell wrote:
>> On 08/11/2017 05:53 AM, Florian Weimer wrote:
>>> I'm resubmitting my old documentation patch (from early 2016) for
>>> reconsideration.
>>>
>>> I reinstated the mention of GNU compiler compatibility for strdupa and
>>> strndupa.
>>
>> Thanks for the updated reference to the previous conversation with Paul Eggert.
>> I read that as a reference for this review.
>>
>> The changes look good to me, they are better than what we had before.
>>
>> At a high level we are removing the limitation about use in parameter lists,
>> and adding warnings about security, all good to me.
>
> What about this node name?
>
> @c Node name preserved for backwards compatibility; the correct
> @c terminology is ``variable length array''.
> @node GNU C Variable-Size Arrays
> @subsubsection ISO C Variable Length Arrays
> @cindex variable length arrays
>
> Should I change it, potentially invalidating hyperlinks?
>
> The node name is quite visible even in the HTML version.
Yes, please change it to match.
I'm not worried about preserving html hyperlinks to individual
sections.
We need to be flexible when it comes to restructuring and improving
our documentation.
Cheers,
Carlos.