This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] i386: Add _startup_sbrk and _startup_fatal [BZ #21913]
On further reflection:
On Mon, Aug 7, 2017 at 8:38 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Mon, Aug 7, 2017 at 4:47 AM, Zack Weinberg <zackw@panix.com> wrote:
>> 1) When you say "Linux/x86", do you mean specifically the old 32-bit
>> ABI, or does this apply to x32 and/or x64 as well?
>
> It only applies to Linux/x86 since Linux/x86-64 always use "syscall"
> which doesn't need TLS nor relocation.
I think of "x86" as the umbrella term nowadays. I think I am not the
only person who would be less confused if, in the future, you would
consistently call it "x86-32" or "i386" when you mean specifically the
old 32-bit ABI and operating mode (i.e. processor is not in long
mode).
>> 2) This is described as fixing a bug; please add a test case. (The bug
>> report describes a crash during 'make install', but that's not good
>> enough, it should be caught by 'make check' pre-installation.)
>
> All static tests fail when GCC is default to PIE.
OK, in that case please mention that in the commit message so that
people doing archaeology know why there doesn't need to be a specific
test case.
zw