This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ #21779] Resolve non-relocatable branch in MicroBlaze pt-vfork.S
On 28/07/2017 09:02, Joseph Myers wrote:
> On Mon, 17 Jul 2017, Adhemerval Zanella wrote:
>
>> On 17/07/2017 09:58, Nathan Rossi wrote:
>>> The relative branch directly to __libc_vfork results in an relocation
>>> that cannot be resolved. Specifically a R_MICROBLAZE_64_PCREL relocation
>>> is created for this branch, however for MicroBlaze R_MICROBLAZE_64_PCREL
>>> type relocations symbols are not resolved. Additionally due to the
>>> branch being located in the .text section the instruction cannot be
>>> rewritten as the section is not writable, and causes a segfault at
>>> runtime when loading libpthread.
>>>
>>> To resolve this issue, ensure the branch is done using PLT. This removes
>>> the need to modify the instruction and trades the R_MICROBLAZE_64_PCREL
>>> for a more common R_MICROBLAZE_JUMP via the PLT.
>>>
>>> 2017-07-17 Nathan Rossi <nathan@nathanrossi.com>
>>>
>>> [BZ #21779]
>>> * sysdeps/unix/sysv/linux/microblaze/pt-vfork.S: Branch using PLT
>>
>> LGTM, cross make clean shows no regression. Since you seem to have access
>> to a microblaze ystem, it would be useful if you have time to run the
>> complete make check so we can update the 2.26 release wike [1].
>
> It looks like neither this nor the ulps update has been committed?
>
I will take care of these.