This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove Roland McGrath et al. from libc.so banner
On 07/27/2017 08:33 PM, Joseph Myers wrote:
> On Wed, 26 Jul 2017, Carlos O'Donell wrote:
>
>> We made good step forward by removing source 'Contributed by'
>> entries, and we should continue progress in that direction.
>
> We've not yet removed them from existing source files (just stopped adding
> them in new files). Perhaps we should remove them from existing files
> (especially given how often patches appear with a completely inaccurate
> "Contributed by" because someone copied a random source file as the basis
> of a new one).
>
> (Note: some source files have "Contributed by" comments extending over
> more than one source line; removal would need to allow for that rather
> than just blindly removing the first line where the words "Contributed by"
> appear. Also, if removing them, make sure the person named is
> sufficiently credited in contrib.texi rather than being absent there or
> only having a small unrepresentative set of their contributions
> mentioned.)
I agree, removal of existing "Contributed by" should involve a human
and proper attribution in contrib.texi for such contributions.
--
Cheers,
Carlos.