This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] manual: Refactor documentation of CHAR_BIT.
- From: Florian Weimer <fweimer at redhat dot com>
- To: Rical Jasan <ricaljasan at pacific dot net>, libc-alpha at sourceware dot org
- Cc: Joseph Myers <joseph at codesourcery dot com>, Zack Weinberg <zackw at panix dot com>, Carlos O'Donell <carlos at redhat dot com>, Michael Kerrisk <mtk dot manpages at gmail dot com>
- Date: Thu, 27 Jul 2017 13:31:56 +0200
- Subject: Re: [PATCH v3] manual: Refactor documentation of CHAR_BIT.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1D654C081F57
- References: <20170620112321.29338-1-ricaljasan@pacific.net> <20170620134418.31324-1-ricaljasan@pacific.net> <6d41a281-ca99-578d-e095-5c21f7c7fae4@redhat.com> <59b59883-baa0-007f-b450-f5eb44e15c8e@pacific.net>
On 07/27/2017 01:28 PM, Rical Jasan wrote:
> On 06/22/2017 06:23 AM, Florian Weimer wrote:
>> On 06/20/2017 03:44 PM, Rical Jasan wrote:
>>> @@ -628,11 +628,10 @@ There is no operator in the C language that can give you the number of
>>> bits in an integer data type. But you can compute it from the macro
>>> @code{CHAR_BIT}, defined in the header file @file{limits.h}.
>>
>> Sorry for scope creep, but the paragraph is inaccurate: We now have
>> *_WIDTH macros, and you actually cannot easily compute the number of
>> usable bits in a portable manner.
>>
>> Rest of the patch looks fine to me.
>>
>> Thanks,
>> Florian
>
> Can I commit the refactoring [1] and prepare a follow-up patch? The
> issues you point out in the diff context go even further in this
> section.
Sure, please go ahead. Note that the hard freeze is starting really
soon now.
Thanks,
Florian