This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/1] Fix LC_MONETARY for ta_LK
- From: Mike FABIAN <mfabian at redhat dot com>
- To: Akhilesh Kumar <akhilesh dot k at samsung dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 26 Jul 2017 12:49:53 +0200
- Subject: Re: [PATCH 1/1] Fix LC_MONETARY for ta_LK
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=mfabian at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E915587649
- References: <CGME20170726102614epcas5p4ef8659e8a44219245d9f11d1d07fefb5@epcas5p4.samsung.com> <1501064540-16588-1-git-send-email-akhilesh.k@samsung.com>
Akhilesh Kumar <akhilesh.k@samsung.com> さんはかきました:
> [BZ #21839]
> * locales/ta_LK (LC_MONETARY, LC_NUMERIC..): Fix
>
> Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
> ---
> localedata/locales/ta_LK | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/localedata/locales/ta_LK b/localedata/locales/ta_LK
> index 94cd58f..e585ca4 100644
> --- a/localedata/locales/ta_LK
> +++ b/localedata/locales/ta_LK
> @@ -46,11 +46,11 @@ category "i18n:2012";LC_MEASUREMENT
> END LC_IDENTIFICATION
>
> LC_COLLATE
> -copy "ta_IN"
> +copy "si_LK"
> END LC_COLLATE
That is wrong because collation depends on the language, not the
country. It does not make a difference in this case because both
ta_IN and si_LK just use “copy "iso14651_t1"”. But I nevertheless
consider this wrong.
> LC_CTYPE
> -copy "ta_IN"
> +copy "si_LK"
> END LC_CTYPE
This is certainly wrong because the LC_CTYPE part in ta_IN actually
does more than the standard "copy" and "include".
LC_CTYPE information also depends on the language, so you should
not copy this from a different language.
> LC_MESSAGES
> @@ -58,11 +58,11 @@ copy "ta_IN"
> END LC_MESSAGES
>
> LC_MONETARY
> -copy "ta_IN"
> +copy "si_LK"
> END LC_MONETARY
This is correct because Tamil speaking people living in Sri Lanka
will use the money from Sri Lanka.
> LC_NUMERIC
> -copy "ta_IN"
> +copy "si_LK"
> END LC_NUMERIC
Doesn’t the number formatting also depend on the language and not so
much on the country?
> LC_TIME
--
Mike FABIAN <mfabian@redhat.com>
睡眠不足はいい仕事の敵だ。