This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch] Fix nss/nss_test1.c compile with latest GCC
- From: DJ Delorie <dj at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: sellcey at cavium dot com, libc-alpha at sourceware dot org
- Date: Fri, 21 Jul 2017 19:23:30 -0400
- Subject: Re: [Patch] Fix nss/nss_test1.c compile with latest GCC
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dj at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9A9C085545
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9A9C085545
I think the right solution is to fix test5. I suspect that leaving in
"bad" default data is a good test for a properly configured test,a and
we might want to add some "bad" default group data as well.
diff --git a/nss/tst-nss-test5.c b/nss/tst-nss-test5.c
index b70f21e..fef41f0 100644
--- a/nss/tst-nss-test5.c
+++ b/nss/tst-nss-test5.c
@@ -65,7 +65,7 @@ do_test (void)
int i;
struct passwd *p;
- __nss_configure_lookup ("passwd", "test1 test2");
+ __nss_configure_lookup ("passwd", "test1");
setpwent ();