This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch] Fix localedata test builds with latest GCC
- From: Steve Ellcey <sellcey at cavium dot com>
- To: Zack Weinberg <zackw at panix dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, Siddhesh Poyarekar <siddhesh at sourceware dot org>
- Date: Fri, 21 Jul 2017 10:11:15 -0700
- Subject: Re: [Patch] Fix localedata test builds with latest GCC
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Steve dot Ellcey at cavium dot com;
- References: <201707192014.v6JKE6JV001711@sellcey-dt.caveonetworks.com> <CAKCAbMjU_ydLDP-CpO2TU5Xj92x9Yec77R7eGNYtxARYppQ58w@mail.gmail.com>
- Reply-to: sellcey at cavium dot com
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Wed, 2017-07-19 at 15:20 -0500, Zack Weinberg wrote:
> On Wed, Jul 19, 2017 at 3:14 PM, Steve Ellcey <sellcey@cavium.com>
> wrote:
> >
> > While testing the latest glibc sources with the latest (ToT) GCC, I ran
> > into some build failures (during testing, not during the glibc build).
> > This patch fixes the build failures in the localedata subdirectory. I
> > believe these started failing with this GCC patch:
> >
> > https://gcc.gnu.org/ml/gcc-patches/2017-06/msg00537.html
> >
> > It does not look like older GCC's complain about not understanding this
> > option so there does not seem to be any need to conditionalize its usage.
> I can't conveniently experiment with GCC 8.x right now, but this seems
> like the right general idea.
>
> zw
Does anyone else have any comments, pro or con, on this patch? I would
like to check it in today for 2.26 if there are no objections, but it
is certainly not a showstopper if there are objections.
Steve Ellcey
sellcey@cavium.com