This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix range check in do_tunable_update_val
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Alexey Makhalov <amakhalov at vmware dot com>, libc-alpha at sourceware dot org
- Date: Wed, 19 Jul 2017 21:43:38 -0400
- Subject: Re: [PATCH] Fix range check in do_tunable_update_val
- Authentication-results: sourceware.org; auth=none
- References: <20170719213438.24573-1-amakhalov@vmware.com>
On 07/19/2017 05:34 PM, Alexey Makhalov wrote:
> Current implementation of tunables does not set arena_max and arena_test
> values. Any value provided by glibc.malloc.arena_max and
> glibc.malloc.arena_test parameters is ignored.
>
> These tunables have minval value set to 1 (see elf/dl-tunables.list file)
> and undefined maxval value. In that case default value (which is 0. see
> scripts/gen-tunables.awk) is being used to set maxval.
Alexey,
Thank you very much for continuing your contributions!
Your patch has ~10-14 lines of legally significant changes.
Given that VMWare has already contributed ~6 legally significant lines of
code with the pthread_create swbz#20116 changes that we worked on together,
this means we need to continue our discussions about copyright assignment
before we can continue to accept any further patches.
As a reminder, please review the contribution checklist:
https://sourceware.org/glibc/wiki/Contribution%20checklist
--
Cheers,
Carlos.