This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch] Fix nss/nss_test1.c compile with latest GCC
- From: DJ Delorie <dj at redhat dot com>
- To: sellcey at cavium dot com
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 19 Jul 2017 19:13:07 -0400
- Subject: Re: [Patch] Fix nss/nss_test1.c compile with latest GCC
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dj at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 6312E356CF
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6312E356CF
Steve Ellcey <sellcey@cavium.com> writes:
> I think this is due to new error checking added to GCC and in this
> case I think that GCC is correct in its error. We should
> be using the default_pwd_data in this expression and not pwd_data.
Correct, although no existing tests actually use that data, so the bug
(and the fix) do not affect test results.
> This patch fixes the proglem, OK for checkin?
I was going to check in the same patch... but my rawhide gcc didn't give
a warning so I haddn't yet confirmed it.
So LGTM :-)
Thanks!