This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Fix nss/nss_test1.c compile with latest GCC


Steve Ellcey <sellcey@cavium.com> writes:
> I think this is due to new error checking added to GCC and in this
> case I think that GCC is correct in its error.  We should
> be using the default_pwd_data in this expression and not pwd_data.

Correct, although no existing tests actually use that data, so the bug
(and the fix) do not affect test results.

> This patch fixes the proglem, OK for checkin?

I was going to check in the same patch... but my rawhide gcc didn't give
a warning so I haddn't yet confirmed it.

So LGTM :-)

Thanks!


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]