This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [ARM] Fix ld.so crash when built using Binutils 2.29
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Phil Blundell <pb at pbcl dot net>, Jiong Wang <jiong dot wang at foss dot arm dot com>, libc-alpha at sourceware dot org
- Date: Thu, 13 Jul 2017 08:12:53 -0400
- Subject: Re: [ARM] Fix ld.so crash when built using Binutils 2.29
- Authentication-results: sourceware.org; auth=none
- References: <065a8567-cfca-989b-587b-70584035f529@foss.arm.com> <1499946085.6717.110.camel@pbcl.net>
On 07/13/2017 07:41 AM, Phil Blundell wrote:
> On Wed, 2017-07-12 at 17:13 +0100, Jiong Wang wrote:
>>
>
>> 2017-07-12 Jiong Wang <jiong.wang@arm.com>
>>
>> * sysdeps/arm/dl-machine.h (elf_machine_load_address): Also
>> strip bit 0
>> of pcrel_address under Thumb mode.
>
> It seems a bit unfortunate that the semantics of the ADR instruction
> have changed in this way (after nearly two decades of the old
> behaviour) but having reviewed the GAS bug report again I do agree with
> Nick's rationale for doing that. And this patch seems like a
> reasonable way of dealing with it in glibc. So, assuming you have
> tested this with both old and new binutils, it is OK.
$0.02.
I'm already running with this patch in Fedora Rawhide for our Fedora 27
32-bit ARM builds and it fixes the issue with no regressions.
--
Cheers,
Carlos.