This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv2] Fix float128 IFUNC relocations on ppc64le [BZ #21707]
- From: Florian Weimer <fweimer at redhat dot com>
- To: Tulio Magno Quites Machado Filho <tuliom at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org
- Cc: carlos at redhat dot com, joseph at codesourcery dot com, gftg at linux dot vnet dot ibm dot com
- Date: Sat, 8 Jul 2017 21:17:10 +0200
- Subject: Re: [PATCHv2] Fix float128 IFUNC relocations on ppc64le [BZ #21707]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com BFB8488E60
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BFB8488E60
- References: <6cc4b956-0a60-73af-ea6b-08c11cbc2267@redhat.com> <20170708183113.28695-1-tuliom@linux.vnet.ibm.com>
On 07/08/2017 08:31 PM, Tulio Magno Quites Machado Filho wrote:
> Changes since version 1:
>
> - Added a testcase. This is now validating both statically and
> dynamically linked executables.
> - Fixed an issue in the $(foreach ..) in sysdeps/powerpc/powerpc64le/Makefile.
> - Added a comment to csu/libc-start.c
> - Added a comment to csu/libc-tls.c
>
> -- 8< --
>
> The patch proposed by Peter Bergner [1] to libgc in order to fix
Typo, should be “libgcc”.
> +__thread int bar;
> +static int * bar_ptr = NULL;
No space after “*”?
> + else {
> + printf ("FAIL: IFUNC resolver not called once.\n");
> + ret = 1;
> + }
> +
> + if (&bar == bar_ptr)
> + printf ("PASS: Address read from IFUNC resolver is correct.\n");
> + else {
> + printf ("FAIL: Address read from IFUNC resolver is incorrect.\n");
> + ret = 1;
> + }
The “{” should be on its own line.
Thanks,
Florian