This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/1] Added Samoan language locale for Samoa

From: Mike FABIAN <mfabian at redhat dot com>
To: Akhilesh Kumar <akhilesh dot k at samsung dot com>
Cc: libc-alpha at sourceware dot org, pankaj dot m at samsung dot com
Date: Fri, 07 Jul 2017 16:41:28 +0200
Subject: Re: [PATCH 1/1] Added Samoan language locale for Samoa
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=mfabian at redhat dot com
Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 905C1267CE
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 905C1267CE
References: <CGME20170705053323epcas5p400ef46d61b1fc317b107c31c63c51bd5@epcas5p4.samsung.com> <1499232622-21049-1-git-send-email-akhilesh.k@samsung.com>

Akhilesh Kumar <akhilesh.k@samsung.com> wrote:

> [BZ #21710] 

> diff --git a/localedata/locales/sm_WS b/localedata/locales/sm_WS
> new file mode 100644
> index 0000000..47a2b34
> --- /dev/null
> +++ b/localedata/locales/sm_WS
> @@ -0,0 +1,220 @@

[...]

> +% Equivalent of AM PM
> +% AM  PM 
> +% Fix Me
> +am_pm	"<U0041><U004D>";/
> +	"i<U0050><U004D>"

The “i” seems to be a typo.
And this is just “AM” and “PM”, no Samoan translations.
I guess that is why you still have the “Fix Me” there.
Can you get the real AM/PM strings for Samoan?

On top of the the AM/PM problem, I suggest the attached changes.

-- 
Mike FABIAN <mfabian@redhat.com>

diff --git a/localedata/locales/sm_WS b/localedata/locales/sm_WS
index 47a2b34a64..8f2a89083d 100644
--- a/localedata/locales/sm_WS
+++ b/localedata/locales/sm_WS
@@ -1,35 +1,35 @@
 comment_char %
 escape_char /
 
-% samoan language locale for Samoa.
+% Samoan language locale for Samoa.
 % Contributed by Akhilesh Kumar <akhilesh.k@samsung.com>.
-% Wrods translated from  https://glosbe.com/sm/en/asu
+% Words translated from  https://glosbe.com/sm/en/asu
 
 LC_IDENTIFICATION
-title       "samoan language locale for Samoa"
+title       "Samoan language locale for Samoa"
 source      "Samsung Electronics Co., Ltd."
 address     ""
 contact     ""
 email       "akhilesh.k@samsung.com"
-tel     ""
-fax     ""
+tel         ""
+fax         ""
 language    "Samoan"
 territory   "Samoa"
 revision    "0.1"
 date        "2017-03-21"
 
-category  "i18n:2017";LC_IDENTIFICATION
-category  "i18n:2017";LC_CTYPE
-category  "i18n:2017";LC_COLLATE
-category  "i18n:2017";LC_TIME
-category  "i18n:2017";LC_NUMERIC
-category  "i18n:2017";LC_MONETARY
-category  "i18n:2017";LC_PAPER
-category  "i18n:2017";LC_MEASUREMENT
-category  "i18n:2017";LC_MESSAGES
-category  "i18n:2017";LC_NAME
-category  "i18n:2017";LC_ADDRESS
-category  "i18n:2017";LC_TELEPHONE
+category  "i18n:2012";LC_IDENTIFICATION
+category  "i18n:2012";LC_CTYPE
+category  "i18n:2012";LC_COLLATE
+category  "i18n:2012";LC_TIME
+category  "i18n:2012";LC_NUMERIC
+category  "i18n:2012";LC_MONETARY
+category  "i18n:2012";LC_PAPER
+category  "i18n:2012";LC_MEASUREMENT
+category  "i18n:2012";LC_MESSAGES
+category  "i18n:2012";LC_NAME
+category  "i18n:2012";LC_ADDRESS
+category  "i18n:2012";LC_TELEPHONE
 END LC_IDENTIFICATION
 
 LC_CTYPE
@@ -42,17 +42,17 @@ END LC_CTYPE
 
 LC_COLLATE
 % Copy the template from ISO/IEC 3166
-copy "iso14651_t1" 
+copy "iso14651_t1"
 END LC_COLLATE
 
 LC_TIME
 % Full month names
-% Ianuari, Fepuari, Mati, Aperila, Me, Iuni,Iulai, Auguso, Setema,Oketopa,Novema, Tesema 
+% Ianuari, Fepuari, Mati, Aperila, Me, Iuni, Iulai, Auguso, Setema, Oketopa, Novema, Tesema
 % http://samoan.manuatele.net/times.html
 mon	"<U0049><U0061><U006E><U0075><U0061><U0072><U0069>";/
 	"<U0046><U0065><U0070><U0075><U0061><U0072><U0069>";/
 	"<U004D><U0061><U0074><U0069>";/
-	"<U0041><U0070><U0065><U0072><U0069><U006C>U0061>";/
+	"<U0041><U0070><U0065><U0072><U0069><U006C><U0061>";/
 	"<U004D><U0065>";/
 	"<U0049><U0075><U006E><U0069>";/
 	"<U0049><U0075><U006C><U0061><U0069>";/
@@ -63,7 +63,7 @@ mon	"<U0049><U0061><U006E><U0075><U0061><U0072><U0069>";/
 	"<U0054><U0065><U0073><U0065><U006D><U0061>"
 
 % Abbreviated month names
-% Ian, Fep, Mat, Ape, Me, Iun,Iul, Aug, Set,Oke,Nov, Tes 
+% Ian, Fep, Mat, Ape, Me, Iun, Iul, Aug, Set, Oke, Nov, Tes
 abmon	"<U0049><U0061><U006E>";/
         "<U0046><U0065><U0070>";/
         "<U004D><U0061><U0074>";/
@@ -79,7 +79,7 @@ abmon	"<U0049><U0061><U006E>";/
 %
 % Full Weekday names
 % http://samoan.manuatele.net/times.html
-% Aso Sa,Aso Gafua,Aso Lua,Aso Lulu,Aso Tofi,Aso Faraile,Aso To'ana'i 
+% Aso Sa, Aso Gafua, Aso Lua, Aso Lulu, Aso Tofi, Aso Faraile, Aso To'ana'i
 day	"<U0041><U0073><U006F><U0020><U0053><U0061>";/
 	"<U0041><U0073><U006F><U0020><U0047><U0061><U0066><U0075><U0061>";/
 	"<U0041><U0073><U006F><U0020><U004C><U0075><U0061>";/
@@ -89,7 +89,7 @@ day	"<U0041><U0073><U006F><U0020><U0053><U0061>";/
 	"<U0041><U0073><U006F><U0020><U0054><U006F><U0027><U0061><U006E><U0061><U0027><U0069>"
 %
 % Abbreviated Weekday names
-% Aso Sa,Aso Gaf,Aso Lua,Aso Lul,Aso Tof,Aso Far,Aso To' 
+% Aso Sa, Aso Gaf, Aso Lua, Aso Lul, Aso Tof, Aso Far, Aso To'
 abday	"<U0041><U0073><U006F><U0020><U0053><U0061>";/
         "<U0041><U0073><U006F><U0020><U0047><U0061><U0066>";/
         "<U0041><U0073><U006F><U0020><U004C><U0075><U0061>";/
@@ -112,10 +112,10 @@ d_fmt	"<U0025><U0064><U002F><U0025><U006D><U002F><U0025><U0059>"
 t_fmt	"<U0025><U0072>"
 %
 % Equivalent of AM PM
-% AM  PM 
+% AM  PM
 % Fix Me
 am_pm	"<U0041><U004D>";/
-	"i<U0050><U004D>"
+	"<U0050><U004D>"
 %
 % Appropriate 12 h time representation
 % %I:%M:%S %p %Z
@@ -129,22 +129,22 @@ decimal_point "<U002E>"
 thousands_sep "<U002C>"
 grouping      3
 END LC_NUMERIC
-%
-% WST 
-% WS$ 
+
 LC_MONETARY
-int_curr_symbol		"<U0057><U0053><U0024><U0020>"
-currency_symbol		"<U0057><U0053><U0054>"
+% WST
+int_curr_symbol	"<U0057><U0053><U0024><U0020>"
+% WS$
+currency_symbol	"<U0057><U0053><U0054>"
 mon_decimal_point	"<U002E>"
 mon_thousands_sep	"<U002C>"
 mon_grouping		3
 positive_sign		""
 negative_sign		"<U002D>"
-int_frac_digits		2
+int_frac_digits	2
 frac_digits		2
 p_cs_precedes		1
 int_p_sep_by_space	1
-p_sep_by_space		1	
+p_sep_by_space		1
 n_cs_precedes		1
 int_n_sep_by_space	1
 n_sep_by_space		1
@@ -157,19 +157,19 @@ copy "i18n"
 END LC_PAPER
 
 LC_MEASUREMENT
-measurement 1
+copy "i18n"
 END LC_MEASUREMENT
 
 LC_MESSAGES
 % ^[yY].*
-yesexpr "<U005E><U005B><U0079><U0059><U005D><U002E><U002A>"
+yesexpr "<U005E><U005B><U002B><U0031><U0069><U0049><U0079><U0059><U005D><U002E><U002A>"
 % ^[nN].*
-noexpr  "<U005E><U005B><U006E><U004E><U005D><U002E><U002A>"
+noexpr  "<U005E><U005B><U002D><U0030><U006C><U004C><U006E><U004E><U005D><U002E><U002A>"
 % https://glosbe.com/en/sm/no
-% ioe 
+% ioe
 yesstr "<U0069><U006F><U0065>"
 % leai
-nostr "<U006E><U006F><U0073><U0074><U0072>"
+nostr "<U006C><U0065><U0061><U0069>"
 END LC_MESSAGES
 
 LC_NAME
@@ -182,7 +182,7 @@ postal_fmt    "<U0025><U0061><U0025><U004E><U0025><U0066><U0025><U004E>/
 <U0020><U0025><U0073><U0020><U0025><U0065><U0020><U0025><U0072><U0025>/
 <U004E><U0025><U0054><U002C><U0020><U0025><U0053><U0020><U0025><U007A><U0025>/
 <U004E><U0025><U0063><U0025><U004E>"
-% Samoa 
+% Samoa
 country_name "<U0053><U0061><U006D><U006F><U0061>"
 % %a %N   %f %N   %d %N   %b %N   %h %s %e %r %N   %T, %c  %N
 country_post "<U0025><U0061><U0020><U0025><U004E><U0020><U0020><U0020><U0025>/
@@ -200,18 +200,18 @@ country_ab3  "<U0057><U0053><U004D>"
 % locale/iso-3166.def
 country_num 882
 % http://www.nationsonline.org/oneworld/international-calling-codes.htm
-% Samoan 
-lang_name    "<U0053><U0061><U006D><U006F><U0061><U006E>"
+% Gagana faÊ»a SÄ?moa
+lang_name    "<U0047><U0061><U0067><U0061><U006E><U0061><U0020><U0066><U0061><U02BB><U0061><U0020><U0053><U0101><U006D><U006F><U0061>"
 % https://en.wikipedia.org/wiki/Samoan_language
-% ISO 639-1 sm. ISO 639-2 smo , ISO 639-3 smo   
+% ISO 639-1 sm, ISO 639-2 smo, ISO 639-3 smo
 lang_ab      "<U0073><U006D>"
 lang_term    "<U0073><U006D><U006F>"
 lang_lib     "<U0073><U006D><U006F>"
 END LC_ADDRESS
 
 LC_TELEPHONE
-% +%c ;%a ;%l
-tel_int_fmt "<U002B><U0025><U0063><U0020><U003B><U0025><U0061><U0020><U003B><U0025><U006C>"
+% +%c %a %l
+tel_int_fmt "<U002B><U0025><U0063><U0020><U0025><U0061><U0020><U0025><U006C>"
 % 00
 int_select  "<U0030><U0030>"
 % https://en.wikipedia.org/wiki/Samoa

References:
- [PATCH 1/1] Added Samoan language locale for Samoa
  - From: Akhilesh Kumar

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]